[tests] migrate group offloading tests to pytest#13234
Merged
Merged
Conversation
dg845
reviewed
May 30, 2026
Collaborator
dg845
left a comment
dg845
left a comment
There was a problem hiding this comment.
Thanks for the PR! I get the following test failures when testing locally:
TestGroupOffloadtest_warning_logged_if_group_offloaded_module_moved_to_acceleratortest_warning_logged_if_group_offloaded_pipe_moved_to_accelerator
TestConditionalModuleGroupOffloadtest_warning_logged_if_group_offloaded_module_moved_to_acceleratortest_warning_logged_if_group_offloaded_pipe_moved_to_accelerator
I think this might be due to the fact that the two tests above use a caplog argument, but no caplog fixture is defined in the file.
Member
Author
|
@dg845 thanks for the review! I have fixed the issue. Also, as an FYI, caplog is a built-in pytest fixture — it doesn't need to be defined in the file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.